Implement canon_path_in_place for backslashes #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I also tried out building LLVM with CMake + n2 (with this Patch) on Windows. It also re-runs CMake on every invocation (I'm now sure, that this is definitely a Bug) and currently fails on: |
|
Re re-running: #40 My recollection is that Ninja on Windows had to do some really tricky stuff to properly model paths with both forward and back slashes. I wonder if this ends up not sufficient. |
evmar
reviewed
Apr 6, 2022
|
#42 some design thoughts on how to do this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I also changed the tests, so that they test for both path separators.
@evmar FYI: This was the final blocker for successfully building CMake on Windows with CMake + n2 😄
However I still need to find out, why it is re-running CMake every time, even if nothing has changed... Or is this normal?